-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spec2cdk): get tag gives null result in Java CDK #29870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
initializer: (props: Expression) => | ||
new CDK_CORE.TagManager( | ||
this.tagManagerVariant(variant), | ||
expr.lit(this.resource.cloudFormationType), | ||
expr.UNDEFINED, | ||
$E(props)[originalName], | ||
expr.object({ tagPropertyName: expr.lit(originalName) }), | ||
), | ||
cfnValueToRender: { | ||
[originalName]: $this.tags.renderTags($this[rawTagsPropName]), | ||
[originalName]: $this.tags.renderTags(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting the changes I made in this PR #28989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the HAS_25610
code? Do we not need to revert that?
[originalName]: $this.tags.renderTags(...(HAS_25610 ? [$this[rawTagsPropName]] : [])),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No HAS_25610
is always set to false before. So for legacy
tagging, this PR changes it back to the original state. For modern
tagging style, we want to keep it as is.
@Mergifyio update |
✅ Branch has been successfully updated |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio update |
☑️ Nothing to do
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #29869
Reason for this change
Without it, it breaks java users who rely on tagging name to generate resource id.
Description of changes
Provide a default value using the initial
tagValue
users provide.Description of how you validated changes
Existing tests all pass. Essentially changing it back to the original state.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license