Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add APPCONFIG and APPCONFIGDATA to InterfaceVpcEndpointAwsService #29408

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat(ec2): add APPCONFIG and APPCONFIGDATA to InterfaceVpcEndpointAwsService #29408

merged 2 commits into from
Mar 8, 2024

Conversation

dhalperi
Copy link
Contributor

@dhalperi dhalperi commented Mar 8, 2024

These are newly available as of 2023-12-11 (announcement) with endpoint names taken from the AWS PrivateLink docs.

Testing: tried them in our environment. This PR is modeled after https://github.com/aws/aws-cdk/pull/21401/files, but the package.json code seems to be gone, and I didn't duplicate the verbose no-op tests that the string is the string.

Reason for this change

New VPC Endpoints exist now.

Description of changes

Add the missing constants.

Description of how you validated changes

Tested appconfigdata in our account.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Yes, and I am an AWS employee.

…Service

These are newly available as of [2023-12-11 (announcement)](https://aws.amazon.com/about-aws/whats-new/2023/12/aws-appconfig-supports-privatelink/)
with endpoint names taken from the [AWS PrivateLink docs](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html).

Testing: tried them in our environment. This PR is modeled after
https://github.com/aws/aws-cdk/pull/21401/files, but the package.json code
seems to be gone, and I didn't duplicate the verbose no-op tests that the
string is the string.
@aws-cdk-automation aws-cdk-automation requested a review from a team March 8, 2024 00:31
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Mar 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@dhalperi
Copy link
Contributor Author

dhalperi commented Mar 8, 2024

Exemption Request (comments below, since I thought maybe it had to be its own comment to trigger the bot)

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 8, 2024
@dhalperi
Copy link
Contributor Author

dhalperi commented Mar 8, 2024

Comments:

  1. Could not find README.md to update. I looked for references to other endpoints, but didn't see any big lists anywhere. This differs from the linked PR that had a bunch of changes to a packages.json file nested inside the ec2 module.
  2. The tests for this seem useless. In the linked PR we add 19 lines of test code that check that the string repositories is repositories.
  3. Similarly, deferring to prior decision on that PR that integration tests are not needed.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 8, 2024
@xazhao xazhao added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Mar 8, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 8, 2024 22:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 8, 2024
Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cd79533
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit baaa50c into aws:main Mar 8, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants