Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): Key Value Store L2 #28473

Merged
merged 8 commits into from
Dec 29, 2023
Merged

feat(cloudfront): Key Value Store L2 #28473

merged 8 commits into from
Dec 29, 2023

Conversation

laurelmay
Copy link
Contributor

This adds an initial resource to support creating a Key Value Store and
specifying an import source. Unfortunately, CloudFormation doesn't seem
to support specifying the KeyValueStoreAssociations property of a
function so there isn't a way to actually associate the store with a
function.

Closes #28377.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Dec 22, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 22, 2023 22:37
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

This adds an initial resource to support creating a Key Value Store and
specifying an import source. Unfortunately, CloudFormation doesn't seem
to support specifying the `KeyValueStoreAssociations` property of a
function so there isn't a way to actually associate the store with a
function.
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 22, 2023 22:46

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @kylelaker

@kaizencc kaizencc changed the title feat(cloudfront): Support creating Key Value Stores feat(cloudfront): Key Value Stores L2 Dec 23, 2023
@kaizencc kaizencc changed the title feat(cloudfront): Key Value Stores L2 feat(cloudfront): Key Value Store L2 Dec 23, 2023
kaizencc
kaizencc previously approved these changes Dec 23, 2023
@mergify mergify bot dismissed kaizencc’s stale review December 26, 2023 20:36

Pull request has been modified.

kaizencc
kaizencc previously approved these changes Dec 28, 2023
Copy link
Contributor

mergify bot commented Dec 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@laurelmay
Copy link
Contributor Author

@kaizencc It looks like Mergify doesn't want to update because of #28481 modifying a file in .github/workflows. I am going to go ahead and manually update this PR which will probably dismiss your review.

@mergify mergify bot dismissed kaizencc’s stale review December 29, 2023 00:32

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 94a7f38
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 030db42 into aws:main Dec 29, 2023
12 checks passed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
This adds an initial resource to support creating a Key Value Store and
specifying an import source. Unfortunately, CloudFormation doesn't seem
to support specifying the `KeyValueStoreAssociations` property of a
function so there isn't a way to actually associate the store with a
function.


Closes aws#28377.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cloudfront: support KeyValueStore
3 participants