Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-event-sources): event source property maxConcurrency is not token-aware #27797

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

rahman
Copy link
Contributor

@rahman rahman commented Nov 1, 2023

Allows a Token to be provided for maxConcurrency without runtime errors

Closes #27796.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2023 15:42
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Nov 1, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rahman
Copy link
Contributor Author

rahman commented Nov 1, 2023

Exemption Request: I'm not sure integration test changes are required as they were not required in a similar PR #20279 but happy to add them if so

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 1, 2023
@sumupitchayan sumupitchayan self-assigned this Nov 2, 2023
@sumupitchayan sumupitchayan added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Nov 6, 2023
sumupitchayan
sumupitchayan previously approved these changes Nov 6, 2023
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 6, 2023 18:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2023
Copy link
Contributor

mergify bot commented Nov 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rahman
Copy link
Contributor Author

rahman commented Nov 7, 2023

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Nov 7, 2023

refresh

✅ Pull request refreshed

@rahman
Copy link
Contributor Author

rahman commented Nov 7, 2023

@sumupitchayan The Queue: Embarked in merge queue failed. Not sure how to resolve it?

The merge queue pull request can't be updated
Details:

Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@rahman
Copy link
Contributor Author

rahman commented Nov 20, 2023

@sumupitchayan The Queue: Embarked in merge queue failed. Not sure how to resolve it?

The merge queue pull request can't be updated
Details:

Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@scanlonp are you able to help with this? I can see you resolved this issue on another pr #27648

@mergify mergify bot dismissed sumupitchayan’s stale review November 20, 2023 09:55

Pull request has been modified.

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@scanlonp
Copy link
Contributor

@rahman what happens is when our workflows are changed, mergify loses permissions until your branch is manually updated. That also clears any approving reviews. This should get it on the right track.

Our build has been acting up. We have some fixes incoming. Once those are in, a quick update here will get it merged!

@rahman
Copy link
Contributor Author

rahman commented Nov 20, 2023

Thanks @scanlonp

@scanlonp
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 20, 2023

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c219a3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 38f54db into aws:main Nov 20, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(lambda-event-sources): Providing a Token for the maxConcurrency results in a runtime error
4 participants