Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ecs): create unit tests for drain hook lambda handler #27725

Open
2 tasks
colifran opened this issue Oct 27, 2023 · 1 comment
Open
2 tasks

(ecs): create unit tests for drain hook lambda handler #27725

colifran opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. p2

Comments

@colifran
Copy link
Contributor

Describe the feature

We need to improve testing coverage of our Lambda handlers. The Lambda handler for drain hooks does not have corresponding unit tests. Unit tests should be created specifically for this handler.

Use Case

Unit tests for the drain hook Lambda handler would improve test coverage and help us find bugs and prevent breaking changes.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.103.1

Environment details (OS name and version, etc.)

MacOS

@colifran colifran added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. @aws-cdk/aws-ecs Related to Amazon Elastic Container p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2023
@msambol
Copy link
Contributor

msambol commented Nov 1, 2023

I'll take this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants