fix(route53): timeouts due to delete-existing-record-set-handler's wait time #27068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onds to regression caused by AWS SDK V3 migration Regression introduced in 399b6bb
aws-cdk-automation
previously requested changes
Sep 8, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
changed the title
kaizencc
changed the title
rix0rrr
previously requested changes
Sep 8, 2023
| @@ -46,7 +46,7 @@ export async function handler(event: AWSLambda.CloudFormationCustomResourceEvent | |||
| }, | |||
| }); | |||
|
|
|||
| await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 60 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id }); | |||
| await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 1800 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id }); | |||
There was a problem hiding this comment.
Should be max 900, better yet 890 (to give Lambda 10s to send a response), and should match the defined Timeout of the Lambda function itself.
kaizencc
changed the title
kaizencc
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
MrArnoldPalmer
approved these changes
Sep 8, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
update-delete-existing-record-set-handler-wait-time
branch
mikewrighton
pushed a commit
that referenced
this pull request
Sep 14, 2023
…it time (#27068) This PR updates the wait time of the `delete-existing-record-set-handler` from 60 to 1800 seconds. Commit 399b6bb upgraded the handler to use the AWS SDK V3 (was V2) and made the following change: ``` - await route53.waitFor('resourceRecordSetsChanged', { Id: changeResourceRecordSets.ChangeInfo.Id }).promise(); + await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 60 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id }) ``` The V2 `route53.waitFor` waits for 1800 seconds (see [reference](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Route53.html#waitFor-property)) > `Waits for the resourceRecordSetsChanged state by periodically calling the underlying [Route53.getChange()](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Route53.html#getChange-property) operation every 30 seconds (at most 60 times).` The new explicit configuration was set to 60 seconds which is too short and caused timeouts and failure in our cloudformation stacks Supersedes and closes #27060 Co-authored-by: Tom Roshko [hi@pistazie.rocks](mailto:hi@pistazie.rocks) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the wait time of the
delete-existing-record-set-handlerfrom 60 to 1800 seconds.Commit 399b6bb upgraded the handler to use the AWS SDK V3 (was V2) and made the following change:
The V2
route53.waitForwaits for 1800 seconds (see reference)The new explicit configuration was set to 60 seconds which is too short and caused timeouts and failure in our cloudformation stacks
Supersedes and closes #27060
Co-authored-by: Tom Roshko hi@pistazie.rocks
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license