fix(custom-resources): AwsCustomResource fails when SDKv3 expects Uint8Array #27065
Conversation
…t8Array The SDKv3 has changed the input representation of `blob` types from `string | Buffer | Uint8Array` to `Uint8Array`. That means all places where customers were passing in `strings` now fail to pass the right kind of value. Similar to #27034, but for `AwsCustomResource`.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
|
||
| expect(kmsMock).toHaveReceivedCommandWith(EncryptCommand, { | ||
| KeyId: 'key-id', | ||
| Plaintext: new Uint8Array([ |
There was a problem hiding this comment.
wait the field named Plaintext is Uint8Array? 😕
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…t8Array (#27065) The SDKv3 has changed the input representation of `blob` types from `string | Buffer | Uint8Array` to `Uint8Array`. That means all places where customers were passing in `strings` now fail to pass the right kind of value. Similar to #27034, but for `AwsCustomResource`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The SDKv3 has changed the input representation of
blobtypes fromstring | Buffer | Uint8ArraytoUint8Array. That means all places where customers were passing instringsnow fail to pass the right kind of value.Similar to #27034, but for
AwsCustomResource.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license