fix(custom-resource): ignoreErrorCodesMatching broken on sdk v3
#26430
Conversation
| @@ -45,7 +45,7 @@ export class LogGroupResourcePolicy extends cr.AwsCustomResource { | |||
| parameters: { | |||
| policyName: policyName, | |||
| }, | |||
| ignoreErrorCodesMatching: '400', | |||
There was a problem hiding this comment.
This was just flag out wrong...right?
There was a problem hiding this comment.
I guess the API says "error code"....
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
iliapolo
changed the title
ignoreErrorCodesMatching broken on sdk v3ignoreErrorCodesMatching broken on sdk v3
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -45,7 +45,7 @@ export class LogGroupResourcePolicy extends cr.AwsCustomResource { | |||
| parameters: { | |||
| policyName: policyName, | |||
| }, | |||
| ignoreErrorCodesMatching: '400', | |||
There was a problem hiding this comment.
I guess the API says "error code"....
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…s#26430) We were using `e.code` to regex match against, but this doesn't exist in v3. Instead, use the `.name` property or the class name of the exception via `e.constructor.name`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We were using
e.codeto regex match against, but this doesn't exist in v3. Instead, use the.nameproperty or the class name of the exception viae.constructor.name.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license