Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicecatalogappregistry): Imported attribute group cannot be associated to an application #24960

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

liwewang-amazon
Copy link
Contributor

@liwewang-amazon liwewang-amazon commented Apr 6, 2023

associateWith was not in IAttributeGroup interface. This makes AttributeGroup.fromAttributeGroupArn() couldn't use associateWith method.

This commit moves associateWith toIAttributeGroup interface, so that imported attribute group can use associateWith to an application.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Apr 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 6, 2023 04:28
@liwewang-amazon liwewang-amazon changed the title feat(servicecatalogappregistry): Import existing attribute group cannot use associateWith method feat(servicecatalogappregistry): Imported attribute group cannot use associateWith method Apr 6, 2023
@liwewang-amazon liwewang-amazon changed the title feat(servicecatalogappregistry): Imported attribute group cannot use associateWith method feat(servicecatalogappregistry): Imported attribute group cannot be associated to an application Apr 6, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@liwewang-amazon liwewang-amazon changed the title feat(servicecatalogappregistry): Imported attribute group cannot be associated to an application fix(servicecatalogappregistry): Imported attribute group cannot be associated to an application Apr 6, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 6, 2023 04:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@liwewang-amazon liwewang-amazon marked this pull request as ready for review April 6, 2023 06:31
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2ae86f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4c2e7d6 into aws:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants