Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events-targets): parameter JobName can exceed limit of 128 characters #24786

Merged
merged 4 commits into from
Apr 12, 2023
Merged

fix(events-targets): parameter JobName can exceed limit of 128 characters #24786

merged 4 commits into from
Apr 12, 2023

Conversation

lpizzinidev
Copy link
Contributor

@lpizzinidev lpizzinidev commented Mar 25, 2023 •
edited
Loading

BatchJob should generate a JobName with a length smaller than 128 characters, otherwise, it will fail during synth.

Closes #24654.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Mar 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 25, 2023 11:19
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Mar 25, 2023
@lpizzinidev lpizzinidev changed the title fix(events-targets): parameter JobName can exceed limit of 128 characters (under feature flags) fix(events-targets): parameter JobName can exceed limit of 128 characters (under feature flag) Mar 27, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Overall this looks good. However, we don't need a feature flag in this case because this is a non-stateful resource.

@lpizzinidev lpizzinidev mentioned this pull request Mar 30, 2023
Merged
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

6 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@lpizzinidev lpizzinidev changed the title fix(events-targets): parameter JobName can exceed limit of 128 characters (under feature flag) fix(events-targets): parameter JobName can exceed limit of 128 characters Apr 8, 2023
@mergify mergify bot dismissed TheRealAmazonKendra’s stale review April 8, 2023 09:42

Pull request has been modified.

aws-cdk-automation
aws-cdk-automation previously requested changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 8, 2023 13:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

otaviomacedo
otaviomacedo previously approved these changes Apr 11, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed otaviomacedo’s stale review April 12, 2023 21:44

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5fa2f09
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 923b9f1 into aws:main Apr 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@otaviomacedo otaviomacedo otaviomacedo left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-events): Automatically Generated JobName Must Be Shorter Than 128 Char Long
4 participants
@lpizzinidev @aws-cdk-automation @otaviomacedo @TheRealAmazonKendra