Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): CFN-init support for systemd #24683

Merged
merged 5 commits into from
Mar 21, 2023
Merged

feat(ec2): CFN-init support for systemd #24683

merged 5 commits into from
Mar 21, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 18, 2023

CFN-init can be used to install software onto EC2 Instances that are created using CloudFormation.

CFN init supports SystemD, but this was not yet available in CDK. This PR adds support for SystemD. It also adds a helper function to create a simple SystemD config files for your own services.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

CFN-init can be used to install software onto EC2 Instances that are
created using CloudFormation.

CFN init supports SystemD, but this was not yet available in CDK. This
PR adds support for SystemD. It also adds a helper function to create
a simple SystemD config files for your own services.
@rix0rrr rix0rrr requested a review from a team March 18, 2023 20:17
@rix0rrr rix0rrr self-assigned this Mar 18, 2023
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Mar 18, 2023

(Tests forthcoming)

@github-actions github-actions bot added the p2 label Mar 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 18, 2023 20:18
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 20, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 20, 2023 13:16

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@MrArnoldPalmer MrArnoldPalmer added the pr/do-not-merge This PR should not be merged at this time. label Mar 20, 2023
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a question on some possibly leftover code in the integ test so added DNM.

});
instance.role.addManagedPolicy(iam.ManagedPolicy.fromAwsManagedPolicyName('AmazonSSMManagedInstanceCore'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the managed policy addition necessary or was this just for your own testing with session-manager or something?

Copy link
Contributor Author

@rix0rrr rix0rrr Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my own testing, but doesn't really hurt for it to be here I thought.

@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Mar 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e7be79f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f3fe8e1 into main Mar 21, 2023
@mergify mergify bot deleted the huijbers/systemd branch March 21, 2023 09:53
@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
CFN-init can be used to install software onto EC2 Instances that are created using CloudFormation.

CFN init supports SystemD, but this was not yet available in CDK. This PR adds support for SystemD. It also adds a helper function to create a simple SystemD config files for your own services.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants