Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redshift): Column ids were not being default assigned #24546

Merged
merged 13 commits into from
Apr 12, 2023
Merged

fix(redshift): Column ids were not being default assigned #24546

merged 13 commits into from
Apr 12, 2023

Conversation

Rizxcviii
Copy link
Contributor

The side effect to add the column ids, if not present, was not being performed. This functionality was supposed to be added, but was overlooked.

Closes #24545.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 9, 2023 11:50
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK bug This issue is a bug. p2 labels Mar 9, 2023
@Rizxcviii Rizxcviii changed the title fix(redshift): Column ids were not appended, if not assigned as an attribute. fix(redshift): Column ids were not being default assigned Mar 9, 2023
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Mar 9, 2023
packages/@aws-cdk/aws-redshift/test/table.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift/lib/table.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review March 10, 2023 11:14

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from comcalvi March 10, 2023 11:57
@Rizxcviii
Copy link
Contributor Author

Is it possible to get this reviewed?

Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this review

packages/@aws-cdk/aws-redshift/test/table.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift/lib/table.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review April 12, 2023 12:10

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from comcalvi April 12, 2023 13:09
comcalvi
comcalvi previously approved these changes Apr 12, 2023
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed comcalvi’s stale review April 12, 2023 21:42

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c8115af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8a655bd into aws:main Apr 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redshift: no default id being assigned
4 participants