Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(servicecatalog): wrong asset path is generated in case outdir is absolute #24393

Merged
merged 2 commits into from
Mar 1, 2023
Merged

fix(servicecatalog): wrong asset path is generated in case outdir is absolute #24393

merged 2 commits into from
Mar 1, 2023

Conversation

bruecktech
Copy link
Contributor

In case we get an absolute path like /tmp/foobar then ./ is always prepended which makes the assetPath relative to the current directory.

Fixes #24392

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 1, 2023 08:21
@github-actions github-actions bot added bug This issue is a bug. p2 labels Mar 1, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bruecktech
fix(servicecatalog): wrong asset path is generated in case outdir is …
37574af 
…an absolute path

In case we get an absolute path like `/tmp/foobar` then `./` is always prepended which makes the assetPath relative to the current directory.
@bruecktech
Copy link
Contributor Author

Exemption Request:
this change does not influence the resulting template, it only fixes a problem where synthesis does not work at all.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 1, 2023
@TheRealAmazonKendra
Copy link
Contributor

Exemption Request: this change does not influence the resulting template, it only fixes a problem where synthesis does not work at all.

Totally agreed. Your unit test covers this fix perfectly well. Adding exemption.

@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Mar 1, 2023
TheRealAmazonKendra
TheRealAmazonKendra approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for catching this!

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 1, 2023 18:35

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 74a73f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0ebbf58 into aws:main Mar 1, 2023
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
@bruecktech @homakk
fix(servicecatalog): wrong asset path is generated in case outdir is …
9b7be69 
…absolute (aws#24393)

In case we get an absolute path like `/tmp/foobar` then `./` is always prepended which makes the assetPath relative to the current directory.

Fixes aws#24392

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

servicecatalog: wrong asset path is generated in case outdir is an absolute path
3 participants
@bruecktech @TheRealAmazonKendra @aws-cdk-automation