feat(opensearch): add support for latest amazon opensearch service 2.3 #22943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
github-actions
bot
added
feature-request
agusti-t
force-pushed
the
OpenSearch_2_3
branch
3 times, most recently
from
4346e92 to
eecb475
Compare
TheRealAmazonKendra
previously requested changes
Nov 21, 2022
There was a problem hiding this comment.
Thank you for your contribution!
The minimal changes in the snapshot of the integration test usually indicates that the tests weren't actually run. Please revert the change in the snapshot and run yarn integ --update-on-failed to validate this change and to produce the new snapshots. I also notice that the integ test isn't using the new IntegTest construct. Please update that.
agusti-t
force-pushed
the
OpenSearch_2_3
branch
from
eecb475 to
d2313a4
Compare
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
aws-cdk-automation
previously requested changes
Nov 22, 2022
agusti-t
force-pushed
the
OpenSearch_2_3
branch
2 times, most recently
from
d2313a4 to
99d7141
Compare
Thanks @TheRealAmazonKendra for the review, I tried using the new Any idea what it could be? I tried looking it up without being able to find anything. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
TheRealAmazonKendra
previously requested changes
Nov 23, 2022
There was a problem hiding this comment.
Please see my comments inline.
We had a bug that was causing your test failures. I updated your branch to be up-to-date with main so the fix is in there now. You should now be able to run yarn integ --update-on-failed and get the correct output. Note that you may need to clean the generated files from the build because the test runner is expecting to see certain files that don't exist due to the update in stack name and using the new IntegTest construct.
Please let me know if you have any questions about this.
agusti-t
force-pushed
the
OpenSearch_2_3
branch
from
9753d8a to
e1729c5
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
agusti-t
force-pushed
the
OpenSearch_2_3
branch
from
e1729c5 to
fe52135
Compare
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
|
@TheRealAmazonKendra Trying again, it took me a while to be able to run the tests with Anyway, it worked on my machine now and I committed everything, but I ask you to please check commits (1, 2) because I am not sure if these files should be committed. Of course the rest of the commits should be checked too. |
agusti-t
force-pushed
the
OpenSearch_2_3
branch
from
fe52135 to
7e63111
Compare
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
@Mergifyio update |
❌ Base branch update has failedmerge conflict between base and head |
agusti-t
force-pushed
the
OpenSearch_2_3
branch
5 times, most recently
from
62a6fd5 to
7bfcec2
Compare
agusti-t
force-pushed
the
OpenSearch_2_3
branch
from
7bfcec2 to
af731e4
Compare
agusti-t
force-pushed
the
OpenSearch_2_3
branch
from
af731e4 to
0f70273
Compare
| @@ -183,8 +190,14 @@ test('grants kms permissions if needed', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| test('minimal example renders correctly', () => { | |||
| new Domain(stack, 'Domain', { version: defaultVersion }); | |||
| each([ | |||
There was a problem hiding this comment.
Fantastic, thank you!
TheRealAmazonKendra
approved these changes
Jan 14, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
DerkSchooltink
pushed a commit
to DerkSchooltink/aws-cdk
that referenced
this pull request
Jan 23, 2023
aws#22943) fixes aws#22942 Description: AWS Launched the support for Amazon OpenSearch Service 2.3 as per the announcement here: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-opensearch-service-supports-opensearch-version-2-3/ AWS CDK does not support the latest version yet, and can not create an OpenSearch cluster with CDK using 2.3. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22942
Description:
AWS Launched the support for Amazon OpenSearch Service 2.3 as per the announcement here: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-opensearch-service-supports-opensearch-version-2-3/
AWS CDK does not support the latest version yet, and can not create an OpenSearch cluster with CDK using 2.3.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license