Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(msk): added msk cluster sasl iam property #21798

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

crisboarna
Copy link
Contributor

@crisboarna crisboarna commented Aug 29, 2022

When accessing the bootstrap brokers of a cluster configured with property

clientAuthentication: msk.ClientAuthentication.sasl({ iam: true })

One can access the bootstrap brokers from the command line:

aws kafka get-bootstrap-brokers --cluster-arn <ClusterArn>

This will return an object:

{
    "BootstrapBrokerStringSaslIam": "..."
}

This PR adds the ability to access the bootstrap brokers directly as a property of the Kafka cluster. This can now be
done via the cluster.bootstrapBrokersSaslIam property.

Fixes #18355


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 29, 2022

@github-actions github-actions bot added the p2 label Aug 29, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 29, 2022 06:21
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Aug 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cbf48d5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d30a530 into aws:main Aug 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
When accessing the bootstrap brokers of a cluster configured with property

`clientAuthentication: msk.ClientAuthentication.sasl({ iam: true })`

One can access the bootstrap brokers from the command line:

`aws kafka get-bootstrap-brokers --cluster-arn <ClusterArn>`

This will return an object:

```
{
    "BootstrapBrokerStringSaslIam": "..."
}
```

This PR adds the ability to access the bootstrap brokers directly as a property of the Kafka cluster. This can now be
done via the `cluster.bootstrapBrokersSaslIam` property.



Fixes aws#18355

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msk: add bootstrapBrokersSaslIam
3 participants