-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(custom-resources): use lambda.Runtime.NODEJS_14_X by default in Provider #19117
Comments
Can you share or link the communication you've gotten from Lambda? I can't seem to find any easily. |
We've not gotten communication from AWS Lambda yet but we're in the process of updating all of our existing CDK projects because of Node 10.x no longer being supported: https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html Since Node 12.x is no longer receiving security updates this spring (https://nodejs.org/en/about/releases/) it felt like a good preventative change to keep ahead of these and use the latest supported Node runtime. |
This week we've received the following guidance from AWS. We have a few custom resources defined in our accounts, which specify non-Node Lambda event handlers, but it seems the CustomResource Provider sets up a NodeJS 12 Lambda itself (description: I'm assuming this issue, once resolved, will upgrade the runtime of these providers. Thanks,
|
Unless I misunderstand, this only resolves the issue for a Route 53 construct which uses custom resources right? The proposed change here is to set it as the default runtime for the custom resource framework itself. |
Thank you. But,I read a source code, the code is fixed now.
|
Sorry, I may be misunderstanding the FIX Issue. |
Provider-framework lambda functions which were created before the PR #20595 seem to remain Node.js 12.x, even if the stacks including custom resources are redeployed. If there's a way to update the existing provider-framework lambda function, it helps. |
This has been fixed, live code shows node 14 |
|
Could this be updated again to version 18? Node 14 is not supported in lambda. |
Description
Similar to #13225, we should update to latest supported Node.js runtime for the custom-resources lambda prior to Node 12 going out of service.
aws-cdk/packages/@aws-cdk/custom-resources/lib/provider-framework/provider.ts
Line 214 in 4e82d36
Use Case
All lambdas created by aws-cdk internally should be updated prior to EOL.
Proposed Solution
Update to
NODEJS_14_X
when creating lambda in custom-resources.Other information
No response
Acknowledge
The text was updated successfully, but these errors were encountered: