Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ec2): Missing enum entries for ec2.SubnetType in CDK-1.x #18292

Closed
anon-44 opened this issue Jan 6, 2022 · 4 comments
Closed

(aws-ec2): Missing enum entries for ec2.SubnetType in CDK-1.x #18292

anon-44 opened this issue Jan 6, 2022 · 4 comments
Assignees
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug.

Comments

@anon-44
Copy link

anon-44 commented Jan 6, 2022

What is the problem?

CDK-1.122.0 introduced new entries in the SubnetType enum, while marking a few old ones as deprecated - 2023004

While the documentation includes the deprecation notice and recommendations for using the new entries, the new entries aren't actually present in the enum.
Docs - https://docs.aws.amazon.com/cdk/api/v1/java/index.html?software/amazon/awscdk/services/ec2/SubnetType.html

CDK-2.x has the entries present(likely because the old entries are removed altogether), but the provided example still references the old entries from CDK-1.x. See https://docs.aws.amazon.com/cdk/api/v2/java/index.html?software/amazon/awscdk/services/ec2/SubnetType.html

Reproduction Steps

N/A

What did you expect to happen?

CDK-1.x should include the suggested new entries in the SubnetType enum along with the old deprecated entries.

What actually happened?

CDK-1.x does not include the suggested new entries in the SubnetType enum.

CDK CLI Version

cdk-1.131.0

Framework Version

No response

Node.js Version

14

OS

MacOS-11.6

Language

Java

Language Version

Java-8

Other information

No response

@anon-44 anon-44 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jan 6, 2022
@peterwoodworth
Copy link
Contributor

Hey @anon-44, thanks for reporting this

This is a known issue for some of our non-TypeScript libraries. The source of this issue is due to JSII and the issue is here. It's not fixed yet, but as you've found, the issue isn't present in v2.

@peterwoodworth peterwoodworth added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2022
@anon-44
Copy link
Author

anon-44 commented Jan 6, 2022

So is the recommendation here to upgrade to v2? Will this not be fixed in v1 releases?

@peterwoodworth
Copy link
Contributor

peterwoodworth commented Jan 6, 2022

There's no ETA for the fix in v1, so you should upgrade to v2 if you don't want to deal with the warnings or use any workarounds (if there are any, I don't know of any off the top of my head).

I recommend upgrading to v2 anyway, I find it a much nicer experience overall. Here's our docs on how to upgrade 🙂

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants