-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws cdk lib): CloudFormationDeployments missing in aws-cdk-lib #18211
Comments
Hey @dreamorosi, It seems to me that this is intentional. This PR was merged for v2 which will prevent "deep imports". That is - only explicitly defined exports can be imported by the user. This isn't explicitly exported, so this class cannot be imported I'm not sure if that is something we'd want to expose to the user, but let me know if you'd be interested in that 🙂 |
@peterwoodworth thanks for the quick reply. Just to clarify, are In any case our use case would really benefit from having these two classes exposed in v2. I know this might fall under this RFC but there's evidence that other Customers are already relying on these classes from v1 (evidence 1, evidence 2) so while I understand that the discussion about CDK programmatic usage is a large one I'm only kindly asking to consider exposing in v2 something that was already available in v1 as an interim solution. |
Currently, these classes are not exposed to the user in v2. Thank you for your request and your reasoning, it's much appreciated 🙂 |
@rix0rrr Is this something we want to be exposed to the user? |
I've been using Was aware from the start that these are not in the official API and might be changed without warning - but they are useful nonetheless as without it I would need to replicate all the CDK-specific business logic. The high-level requirement would be something like: I can live without all the monitoring functionality, as that's really more geared to the CLI. |
@rix0rrr @peterwoodworth any chance we could get an answer on whether this is in the plans or not? Not asking for any kind of ETA, just would like to know if this is something that might become exposed again or if we should just stick with v1 / find an alternative. We are using this in awslabs/aws-lambda-powertools-typescript to run our end to end tests and being able to migrate to |
The CLI cannotbe used in this way. We don't support it and have no compunction about breaking you. In an ideal world the components would have been separated better, and we definitely have an ambition in that direction, but no concrete plans as of yet. If you want to programmatically do a CDK deployment, shell out to the CLI. |
|
General Issue
Unable to find
CloudFormationDeployments
from v1 (exported in'aws-cdk/lib/api/cloudformation-deployments'
) inaws-cdk-lib
(v2)The Question
While writing some e2e tests for a library we are using CDK to provision different stacks for each suite to test the behaviour of our library in an actual Lambda execution environment. We are already able to do so using CDK v1 using something along the lines of:
We would like to migrate this to
aws-cdk-lib
(v2) to get the benefits of the newer version but we are unable to findSdkProvider
andCloudFormationDeployments
in the new version, could you confirm their presence and/or provide an alternative for v2?CDK CLI Version
N/A
Framework Version
2.3.0
Node.js Version
N/A
OS
N/A
Language
Typescript
Language Version
N/A
Other information
Alternatively we have considered using the CloudFormation client from
aws-sdk
to deploy the synthesised template but in doing so we would lose thehotswap
feature which we are using while writing the tests to iterate faster.The text was updated successfully, but these errors were encountered: