fix(secretsmanager): Secret requires KMS key for some same-account access #17812
Conversation
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
kaiz-io
changed the title
kaiz-io
changed the title
github-actions
bot
added
the
@aws-cdk/aws-secretsmanager
kaiz-io
force-pushed
the
awsmikek/secretsmanager
branch
2 times, most recently
from
21b1ec5 to
be003aa
Compare
There was a problem hiding this comment.
Thanks for the contribution, @kaizio !
The change itself looks good -- I think -- however, there are quite a bit of unintentional formatting changes that make it unclear what exactly has changed. Can you please clean up the diff so only the new/changed lines are present?
mergify
bot
dismissed
njlynch’s stale review
Pull request has been modified.
kaiz-io
force-pushed
the
awsmikek/secretsmanager
branch
from
e1a5cdb to
8407187
Compare
|
Got it fixed @njlynch Thanks. Had a bad merge trying to bring some upstream changes in. |
kaiz-io
force-pushed
the
awsmikek/secretsmanager
branch
from
8407187 to
bdbd12e
Compare
kaiz-io
force-pushed
the
awsmikek/secretsmanager
branch
from
bdbd12e to
e54ace3
Compare
kaiz-io
force-pushed
the
awsmikek/secretsmanager
branch
from
e54ace3 to
3603de0
Compare
|
Added two test and renamed the one that was there before. I am testing for grant read without any KMS and one where I am using a different account. Is the way that I am overwriting the "stack" correct? Hard to find an example with search. |
njlynch
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…cess (aws#17812) Fix for aws#15450 Previous code did not check if the account IDs were the different. This checks if CDK is able to resolve the account ids and they are different then fail otherwise let the user create a secret. FYI first PR. Let me know if there is something that I missed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fix for #15450 Previous code did not check if the account IDs were the different. This checks if CDK is able to resolve the account ids and they are different then fail otherwise let the user create a secret.
FYI first PR. Let me know if there is something that I missed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license