(aws_ecs: ContainerImage): why repository_name parameter is depricated?

[TRANTANKHOA]

I noticed in document that there is this parameter for repository_name (Optional[str]) – (deprecated) ECR repository name. It would be something useful in my case since I can use that to have a stable reference to my image instead of the random hash cdk generates. This would help me clean up the ECR from all those obsolete images.

The question is why it is now deprecated?

[peterwoodworth]

Here's the PR which deprecated repositoryName: #5733

The PR doesn't specifically say why this was deprecated, however the comments left an alternative for the user:

aws-cdk/packages/@aws-cdk/aws-ecr-assets/lib/image-asset.ts

Lines 19 to 31 in 65761fe

	/**
	* ECR repository name
	*
	* Specify this property if you need to statically address the image, e.g.
	* from a Kubernetes Pod. Note, this is only the repository name, without the
	* registry and the tag parts.
	*
	* @default - the default ECR repository for CDK assets
	* @deprecated to control the location of docker image assets, please override
	* `Stack.addDockerImageAsset`. this feature will be removed in future
	* releases.
	*/
	readonly repositoryName?: string;

[TRANTANKHOA]

The comment in that PR leads into this rabbit hole I.e. I would have to implement the entire extension instead. Why this has to be so complicated?

[peterwoodworth]

@eladb can you provide your input here? Thanks

[eladb]

Basically the recommended solution is to use https://github.com/wchaws/cdk-ecr-deployment if you wish to deploy docker images.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[TRANTANKHOA]

that doesn't work if the image needs to be referred to in a lambda deployment, since the image isn't available at the time yet I think