fix(core): asset hash of symlinked dir is wrong #16429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the root directory of an asset is a symlink (such as can happen in CDK Pipelines), the asset hash calculation incorrectly doesn't follow the symlink and hashes the link itself it instead. This leads to the asset hash never changing, even though the files inside the directory do change. Instead, we resolve the asset root dir, and make sure to hash the target directory on disk. Handling of symlinks found *inside* the target dir remains unchanged.
|
|
BenChaimberg
approved these changes
Sep 9, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the root directory of an asset is a symlink (such as can happen in
CDK Pipelines), the asset hash calculation incorrectly doesn't follow
the symlink and hashes the link itself it instead.
This leads to the asset hash never changing, even though the files
inside the directory do change.
Instead, we resolve the asset root dir, and make sure to hash the target
directory on disk. Handling of symlinks found inside the target dir
remains unchanged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license