fix(assets): run executable command of container assets in cloud assembly root directory #16094
Conversation
|
|
pgarbe
changed the title
| @@ -183,7 +183,7 @@ describe('external assets', () => { | |||
|
|
|||
| const expectAllSpawns = mockSpawn( | |||
There was a problem hiding this comment.
We need an assertion that verifies that the default is to run next to assets.json, right?
There was a problem hiding this comment.
Yes, that's why I extended the mock of "sometool" so that it also checks that cwd is set to "/external/cdk.out".
peterwoodworth
added
p1
@aws-cdk/assets
|
I'm super eager to get this one reviewed and merged in because it will fix a cross platform build problem I have for an upcoming ECS Anywhere demo app with CDK that I am building. Anything we can do to expedite this one? |
|
@rix0rrr can you take a look? |
mergify
bot
dismissed stale reviews from eladb and rix0rrr
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Runs the executable command of container assets in the cloud assembly root directory and not the current directory.
Could be a breaking change.
fixes #15721
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license