-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-cloudfront): add enabled to web distribution #15433
Conversation
cc @njlynch |
Why is this a |
@peterwoodworth Wasn't sure since it's a "missing" field. Happy to change if that's what it should be. Oh also feat requires a change to readme (pr-linter) but this is an optional field. Thoughts? |
We don't say we currently support this in our I'll make it so an update to the readme isn't mandatory for this PR Thank you for submitting this PR by the way, is there an issue that this PR will close? |
Sure np. No issue is open for it currently; came across it today needed to do a massive update at work :D |
Allows cloudfront web distribution to be enabled or disabled.
@peterwoodworth Change made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the contribution!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Allows cloudfront web distribution to be enabled or disabled. This prop is available in `Distribution` but not `CloudFrontWebDistribution` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows cloudfront web distribution to be enabled or disabled. This prop is available in `Distribution` but not `CloudFrontWebDistribution` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows cloudfront web distribution to be enabled or disabled. This prop is available in
Distribution
but notCloudFrontWebDistribution
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license