(secretsmanager): RDS_DB_CLUSTER/INSTANCE is not available as an attachment type

[quixoticmonk]

Description of the bug:

Python documentation for SecretAttachmentTargetProps refers to using "AttachmentTargetType" as target_type object value. The available values are

• CLUSTER
• REDSHIFT_CLUSTER
• DOCDB_DB_CLUSTER

CLUSTER is marked as deprecated and is recommended to use RDS_DB_CLUSTER which is unavailable in the selections.

Reproduction Steps

• Create a DatabaseSecret entity
• Attempt to attach a cluster endpoint with the secret created
• Reference the SecretAttachmentTargetProps which has a target_type argument.
• Try to bring up the available selections of the target type from secretsmanager.AttachmentTargetType

What did you expect to happen?

Expected the recommended selection to be present as the targettype

What actually happened?

The deprecated value is present , but the recommended value is not.

Environment

• CDK CLI Version : 1.96.0
• Node.js Version: 10.24
• OS : Linux ( Cloud9)
• Language (Version): Python 3.9

---

This is 🐛 Bug Report

[njlynch]

Thanks for the bug report, @quixoticmonk .

This looks to be an issue with our underlying multi-language framework, jsii. I've filed a bug there (aws/jsii#2782) to track the fix.

In the meantime, it's worth noting I think you don't actually need to reference this prop directly. To attach the db secret to your cluster should be as simple as this:

_db_secret.attach(_cluster)

The RDS Cluster class implements the ISecretAttachmentTarget interface, so you don't need to hand-craft the target yourself.

[quixoticmonk]

Aah. Thank you. Confirming that the attach with cluster ref works.

[peterwoodworth]

Closing in favor of #16443

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.