Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigatewayv2): http api - default authorizer options #13172

Merged
merged 31 commits into from
Mar 17, 2021
Merged

feat(apigatewayv2): http api - default authorizer options #13172

merged 31 commits into from
Mar 17, 2021

Conversation

iRoachie
Copy link
Contributor

@iRoachie iRoachie commented Feb 21, 2021 •
edited
Loading

Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iRoachie
feat(apigatewayv2): http api - default authorizer options
253a9b0 
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.
@gitpod-io
Copy link

gitpod-io bot commented Feb 21, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Feb 21, 2021
nija-at
nija-at previously requested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @iRoachie. See my first round of comments below.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts
a953e06 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review February 25, 2021 17:40

Pull request has been modified.

nija-at
nija-at previously requested changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking great @iRoachie. Just some simple comments below around naming, docs and testing.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/route.ts Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/test/http/api.test.ts Show resolved Hide resolved
iRoachie and others added 2 commits February 26, 2021 10:00
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts
764552c 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts
19b1383 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review February 26, 2021 14:02

Pull request has been modified.

nija-at
nija-at previously requested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cod looks good. Could you make the README change you suggested?

packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts
07e1569 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
nija-at
nija-at previously requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this back to request changes for the suggested README updates.

@mergify mergify bot dismissed nija-at’s stale review March 10, 2021 12:42

Pull request has been modified.

@iRoachie iRoachie requested a review from nija-at March 10, 2021 13:18
nija-at
nija-at previously requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iRoachie for cleaning up the README.
Some comments and suggestions on the contents.

packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md Show resolved Hide resolved
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md
1660110 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review March 10, 2021 17:51

Pull request has been modified.

iRoachie and others added 2 commits March 10, 2021 13:51
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md
f56c52a 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2-authorizers/README.md
59f3d52 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
nija-at
nija-at previously approved these changes Mar 10, 2021
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed nija-at’s stale review March 14, 2021 23:39

Pull request has been modified.

@iRoachie
Copy link
Contributor Author

Updated upstream integ test

@iRoachie iRoachie requested a review from nija-at March 15, 2021 01:55
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c96dfe5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 53d9661 into aws:master Mar 17, 2021
@iRoachie
Copy link
Contributor Author

Thanks again @nija-at 💯

@iRoachie iRoachie deleted the ft/default-authorizer branch March 17, 2021 11:02
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 17, 2021
@iRoachie @hollanddd
feat(apigatewayv2): http api - default authorizer options (aws#13172)
580fb14 
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 18, 2021
@iRoachie @hollanddd
feat(apigatewayv2): http api - default authorizer options (aws#13172)
8126696 
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@iRoachie @hollanddd
feat(apigatewayv2): http api - default authorizer options (aws#13172)
ec9ffcc 
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api.

@nija-at this is the bit we forgot In the first PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iRoachie @aws-cdk-automation @nija-at