Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpc: throw an error if subnets() call doesn't match any subnets #1239

Closed
rix0rrr opened this issue Nov 23, 2018 · 1 comment
Closed

vpc: throw an error if subnets() call doesn't match any subnets #1239

rix0rrr opened this issue Nov 23, 2018 · 1 comment
Assignees
@rix0rrr
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 23, 2018 •
edited
Loading

If there are no subnets of a certain type, the subnets() call returns an empty array. An error probably makes more sense. This would have saved Clare from some confusing situations.
@rix0rrr rix0rrr added enhancement @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud labels Nov 23, 2018
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Sep 27, 2019

Already implemented.

@rix0rrr rix0rrr closed this as completed Sep 27, 2019
@sumodgeorge sumodgeorge mentioned this issue Dec 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix0rrr @srchase