Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): add grantConnect for RDS Proxy #12243

Merged
merged 6 commits into from
Dec 28, 2020
Merged

feat(rds): add grantConnect for RDS Proxy #12243

merged 6 commits into from
Dec 28, 2020

Conversation

saudkhanzada
Copy link
Contributor

Closes: #10133

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 27, 2020 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Dec 27, 2020
skinny85
skinny85 previously approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @saudkhanzada ! Feel free to change it from a draft to an actual PR, and I'll be happy to merge this in.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@saudkhanzada saudkhanzada marked this pull request as ready for review December 28, 2020 21:40
@mergify mergify bot dismissed skinny85’s stale review December 28, 2020 21:51

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit eb45ca8 into aws:master Dec 28, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c6ab46c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@flochaz
feat(rds): add grantConnect for RDS Proxy (aws#12243)
811d12d 
Closes: aws#10133

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@skinny85 skinny85 mentioned this pull request Jan 6, 2021
Closed
@jdvornek jdvornek mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rds] provide grant methods for Database Proxy
3 participants
@saudkhanzada @aws-cdk-automation @skinny85