Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): --quiet does not print template in cdk synth #12178

Merged
merged 8 commits into from
Jan 11, 2021
Merged

feat(cli): --quiet does not print template in cdk synth #12178

merged 8 commits into from
Jan 11, 2021

Conversation

briete
Copy link
Contributor

@briete briete commented Dec 21, 2020

fixes #11970


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 21, 2020

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 21, 2020
rix0rrr
rix0rrr previously requested changes Jan 6, 2021
@@ -68,7 +68,8 @@ async function parseCommandLineArguments() {
.option('long', { type: 'boolean', default: false, alias: 'l', desc: 'Display environment information for each stack' }),
)
.command(['synthesize [STACKS..]', 'synth [STACKS..]'], 'Synthesizes and prints the CloudFormation template for this stack', yargs => yargs
.option('exclusively', { type: 'boolean', alias: 'e', desc: 'Only synthesize requested stacks, don\'t include dependencies' }))
.option('exclusively', { type: 'boolean', alias: 'e', desc: 'Only synthesize requested stacks, don\'t include dependencies' })
.option('no-stdout', { type: 'boolean', desc: 'Do not output CloudFormation Template to stdout', default: false }))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call this quiet and alias to q.

@mergify mergify bot dismissed rix0rrr’s stale review January 8, 2021 07:28

Pull request has been modified.

@briete briete requested a review from rix0rrr January 8, 2021 09:31
@briete
Copy link
Contributor Author

briete commented Jan 8, 2021

@rix0rrr Please review again🙇

packages/aws-cdk/README.md Outdated Show resolved Hide resolved
Co-authored-by: Reagan Elm <1347066+relm923@users.noreply.github.com>
@rix0rrr rix0rrr changed the title feat(cli): added option to disable stdout in cdk synth cloudformation… feat(cli): --quiet does not print template in cdk synth Jan 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2c1f77b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 74458a0 into aws:master Jan 11, 2021
@@ -115,6 +115,9 @@ $ cdk synth

$ # Synthesize cloud assembly for StackName, but don't include dependencies
$ cdk synth MyStackName --exclusively

$ # Synthesize cloud assembly for StackName, but don't cloudFormation template output to STDOUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... 'output' cloud formation .......

@briete briete deleted the briete/feature-add-synth-option-no-stdout branch January 13, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cli): cdk synth need to disable printing the Cloudformation Template to console
5 participants