fix(elasticsearch): log policies are overwritten when creating 2 domains which also results in a failure while destroying the stack #12056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue aws#12016 where 2 Domains in same account/region each create & delete LogGroup Resource Policies statically named 'ESLogPolicy'.
|
|
github-actions
bot
added
the
@aws-cdk/aws-elasticsearch
peterb154
force-pushed
the
peterb154/#12016-2-domains-2-stacks
branch
from
c031d3a to
f5764f4
Compare
iliapolo
previously requested changes
Dec 14, 2020
iliapolo
added
the
response-requested
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
…eterb154/aws-cdk into peterb154/aws#12016-2-domains-2-stacks
peterb154
force-pushed
the
peterb154/#12016-2-domains-2-stacks
branch
from
ff5510c to
65c54cc
Compare
iliapolo
changed the title
iliapolo
approved these changes
Dec 14, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
…ins which also results in a failure while destroying the stack (aws#12056) 2 Domains in same account/region each create & delete LogGroup Resource Policies statically named 'ESLogPolicy'. Fixes aws#12016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Domains in same account/region each create & delete LogGroup Resource Policies statically named 'ESLogPolicy'.
Fixes #12016
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license