fix(elasticsearch): Defining 2 domains with logging enabled in the same stack fails on construct id conflict #12055
Conversation
|
|
iliapolo
changed the title
github-actions
bot
added
the
@aws-cdk/aws-elasticsearch
| @@ -81,7 +83,7 @@ describe('log groups', () => { | |||
| SEARCH_SLOW_LOGS: { | |||
| CloudWatchLogsLogGroupArn: { | |||
| 'Fn::GetAtt': [ | |||
| 'SlowSearchLogsE00DC2E7', | |||
| cdkAssert.stringLike(`${logicalId}SlowSearchLogs*`), | |||
There was a problem hiding this comment.
Assert the concrete logical id that contains the domain as well. (in all tests)
There was a problem hiding this comment.
@iliapolo - so we should not use matchers for things like this? I assume that we want the test to break if the logicaIId changes?
There was a problem hiding this comment.
@iliapolo amended the commit with concrete logicalIds
iliapolo
added
the
response-requested
Fixes issue aws#12017 where 2 elastic search Domains with logging enabled and deployed in the same stack fail to synth due to log group logical naming conflict. BREAKING CHANGE: ES Domain LogGroup LogicalId will change, which will trigger new log group resources to be created
peterb154
force-pushed
the
peterb154/#12017-2-esdomains-1-stack
branch
from
9798554 to
c5bb888
Compare
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
removed
the
response-requested
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…me stack fails on construct id conflict (aws#12055) 2 elastic search Domains with logging enabled and deployed in the same stack fail to synth due to log group logical naming conflict. BREAKING CHANGE: ES Domain LogGroup LogicalId will change, which will trigger new log group resources to be created Fixes aws#12017 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 elastic search Domains with logging enabled and deployed in the same stack fail to synth due to log group logical naming conflict.
BREAKING CHANGE: ES Domain LogGroup LogicalId will change, which will trigger new log group resources to be created
Fixes #12017
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license