[ec2] add gp3 support to EbsDeviceVolumeType

[miztiik]

The newly released gp3 volumes are supported by Cloudformation. But aws_cdk.aws_ec2.EbsDeviceVolumeType does not support it yet.
Ref: https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_ec2/EbsDeviceVolumeType.html#aws_cdk.aws_ec2.EbsDeviceVolumeType

Work-around:

perf_server = ebs_gp3_perf_server.node.default_child
# Assuming the gp3 volume is the first device in the list, accessed by index '0'
perf_server.add_property_override("BlockDeviceMappings.0.Ebs.VolumeType", "gp3")

Cdk gives you a warning
[Warning at /stack/Ec2Server] iops will be ignored without volumeType: EbsDeviceVolumeType.IO1 But gp3 allows your to have provisioned IOPS

[NetaNir]

Yup we need to add that type to the enum and modify the conditions to allow it.

[tpunder]

Don't forget about supporting the Throughput and IOPS configuration for GP3 volumes. It probably makes sense also add in IO2 support at the same time too.

[miztiik]

Don't forget about supporting the Throughput and IOPS configuration for GP3 volumes. It probably makes sense also add in IO2 support at the same time too.

Here is the issue for the same - #12052

[kirintwn]

This should be close as #12074 was merged.

[orzikhd]

The change #12074 doesn't include adding GP3 to EmrCreateCluster.EbsBlockDeviceVolumeType

[mmuller88]

Just use that downleveling feature like:

const cfnInstance = instance.node.defaultChild as ec2.CfnInstance;
cfnInstance.blockDeviceMappings = [{
        deviceName: '/dev/sda1',
        ebs: {
          deleteOnTermination: true,
          encrypted: false,
          volumeSize: 2 * 300,
          volumeType: 'gp3',
        },
}];

[ArielPrevu3D]

EbsDeviceOptionsBase needs a throughput option for GP3, to match CloudFormation. It was forgotten in PR #12074 😢

My workaround for a Launch Template in Python:
launch_template.node.default_child.add_property_override("LaunchTemplateData.BlockDeviceMappings.0.Ebs.Throughput", 1000)

[jumic]

There are three topics mentioned in this issue:

• Volume type GP3 in ec2 --> Resolved by PR feat(ec2): Support for new EBS types #12074.
• Volume type GP3 for EmrCreateCluster.EbsBlockDeviceVolumeType --> This must not be implemented because GP3 is not supported there, see service documentation and cloudformation documentation.
• New property Throughput in EbsDeviceOptionsBase. --> New feature request, related to GP3. However, GP3 can also used with the default value for property troughput. @peterwoodworth To keep it clean: should we add a new feature request (low priority) for this property and close this issue?

[peterwoodworth]

@jumic it would be helpful if you create a new feature request for the throughput property! If that property can be used for every interface that extends EbsDeviceOptionsBase (EbsDeviceOptions and EbsDeviceSnapshotOptions) then it would make sense to add the throughput property here, but let's verify with the area owner first.

If this is a wanted change, a check should be put in place to ensure that the throughput property is set only if the volume type is gp3.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[pwrmiller]

@peterwoodworth - This is still an issue in CDK 2.69.0 for AutoScalingGroup block devices. It seems the generic interface has been fixed, but not the interface included with ASG Block Devices (oddly, it uses its own).