Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): fromInterfaceVpcEndpointAttributes: Security Groups should not be required #11857

Conversation

thomaspoignant
Copy link
Contributor

@thomaspoignant thomaspoignant commented Dec 3, 2020

fix: This pull request removes the fact that a security group is mandatory while using fromInterfaceVpcEndpointAttributes.
resolves #11050

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 3, 2020

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@thomaspoignant thomaspoignant changed the title fromInterfaceVpcEndpointAttributes: Security Groups should not be required [ec2] fromInterfaceVpcEndpointAttributes: Security Groups should not be required Dec 3, 2020
@thomaspoignant thomaspoignant changed the title [ec2] fromInterfaceVpcEndpointAttributes: Security Groups should not be required fix(ec2) fromInterfaceVpcEndpointAttributes: Security Groups should not be required Dec 3, 2020
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 3, 2020
@thomaspoignant thomaspoignant changed the title fix(ec2) fromInterfaceVpcEndpointAttributes: Security Groups should not be required fix(ec2): fromInterfaceVpcEndpointAttributes: Security Groups should not be required Dec 3, 2020
@thomaspoignant thomaspoignant force-pushed the fix-fromInterfaceVpcEndpointAttributes-security-groups-mandatory branch from 539f0b6 to 321b01b Compare December 3, 2020 19:55
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2020

@thomaspoignant is not allowed to run commands

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c7f9ec5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 86ae5d6 into aws:master Dec 14, 2020
@thomaspoignant thomaspoignant deleted the fix-fromInterfaceVpcEndpointAttributes-security-groups-mandatory branch December 14, 2020 12:55
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
…not be required (aws#11857)

fix: This pull request removes the fact that a security group is mandatory while using `fromInterfaceVpcEndpointAttributes`.
resolves aws#11050

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ec2] fromInterfaceVpcEndpointAttributes: Security Groups should not be required
3 participants