fix(cfn-include): Fn::FindInMap cannot be used for boolean properties #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including a template that was using an Fn::FindInMap expression for a boolean-typed property
would fail with an error similar to: "Expected 'true' or 'false' for boolean value, got: '${Token[TOKEN.151]}'".
The reason is that our Fn.findInMap() function in core incorrectly assumes Fn::FindInMap
can only return string values.
Change CfnParser to use a new, module-private function Fn._findInMap() that returns an IResolvable.
Fixes aws#11300
|
|
rix0rrr
approved these changes
Nov 6, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a template that was using an
Fn::FindInMapexpression for a boolean-typed propertywould fail with an error similar to:
Expected 'true' or 'false' for boolean value, got: '${Token[TOKEN.151]}'.The reason is that our
Fn.findInMap()function incoreincorrectly assumesFn::FindInMapcan only return string values.
Change
CfnParserto use a new, module-private functionFn._findInMap()that returns anIResolvable.Fixes #11300
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license