-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(region-info): added AppMesh ECR account for eu-south-1 region #11207
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajal-amzn - looks like there are tests in the ecs-service-extensions
module that need to be updated as well.
Pull request has been modified.
|
@rajal-amzn is it #11297 ? - if so, updating the branch should do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests that are broken are directly related to changes in this PR:
i.e. - this expected mappings file is no longer correct because a change was made for eu-south-1
. example
pleas re-run the failing integration test(s)
yarn integ integ.all-service-addons.js integ.multiple-environments.js
they will verify deployment and upon successful deployment, automatically update the .generated
file. please do not modify the generated file(s) directly.
Pull request has been modified.
Fixed the failing tests now. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AppMesh is launched in
eu-south-1
region and has a separate account for storing Envoy images in ECR.Updated the ECR account information.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license