Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(region-info): added AppMesh ECR account for eu-south-1 region #11207

Merged
merged 9 commits into from
Nov 7, 2020

Conversation

rajal-amzn
Copy link
Contributor

@rajal-amzn rajal-amzn commented Oct 29, 2020

AppMesh is launched in eu-south-1 region and has a separate account for storing Envoy images in ECR.
Updated the ECR account information.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 29, 2020

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@rajal-amzn rajal-amzn changed the title Updating AppMesh ECR account for eu-south-1 region fix: updating AppMesh ECR account for eu-south-1 region Oct 29, 2020
@rajal-amzn rajal-amzn changed the title fix: updating AppMesh ECR account for eu-south-1 region fix(eu-south-1): updating AppMesh ECR account for eu-south-1 region Oct 29, 2020
@SomayaB SomayaB changed the title fix(eu-south-1): updating AppMesh ECR account for eu-south-1 region fix(region-info): updating AppMesh ECR account for eu-south-1 region Nov 2, 2020
@shivlaks shivlaks changed the title fix(region-info): updating AppMesh ECR account for eu-south-1 region feat(region-info): added AppMesh ECR account for eu-south-1 region Nov 4, 2020
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajal-amzn - looks like there are tests in the ecs-service-extensions module that need to be updated as well.

@mergify mergify bot dismissed shivlaks’s stale review November 5, 2020 21:52

Pull request has been modified.

@rajal-amzn
Copy link
Contributor Author

@rajal-amzn - looks like there are tests in the ecs-service-extensions module that need to be updated as well.

ecs-service-extensions failed since the old Envoy image version was not present in MXP. The Envoy image is updated to the latest as part of a different PR. Builds pass locally.

@shivlaks
Copy link
Contributor

shivlaks commented Nov 6, 2020

@rajal-amzn - looks like there are tests in the ecs-service-extensions module that need to be updated as well.

ecs-service-extensions failed since the old Envoy image version was not present in MXP. The Envoy image is updated to the latest as part of a different PR. Builds pass locally.

@rajal-amzn is it #11297 ? - if so, updating the branch should do it.

@shivlaks shivlaks added the pr-linter/exempt-readme The PR linter will not require README changes label Nov 6, 2020
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests that are broken are directly related to changes in this PR:

i.e. - this expected mappings file is no longer correct because a change was made for eu-south-1. example

pleas re-run the failing integration test(s)

yarn integ integ.all-service-addons.js integ.multiple-environments.js

they will verify deployment and upon successful deployment, automatically update the .generated file. please do not modify the generated file(s) directly.

@mergify mergify bot dismissed shivlaks’s stale review November 6, 2020 23:56

Pull request has been modified.

@rajal-amzn
Copy link
Contributor Author

tests that are broken are directly related to changes in this PR:

i.e. - this expected mappings file is no longer correct because a change was made for eu-south-1. example

pleas re-run the failing integration test(s)

yarn integ integ.all-service-addons.js integ.multiple-environments.js

they will verify deployment and upon successful deployment, automatically update the .generated file. please do not modify the generated file(s) directly.

Fixed the failing tests now.

@rajal-amzn rajal-amzn closed this Nov 6, 2020
@rajal-amzn rajal-amzn reopened this Nov 6, 2020
@gitpod-io
Copy link

gitpod-io bot commented Nov 6, 2020

shivlaks
shivlaks previously approved these changes Nov 7, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed shivlaks’s stale review November 7, 2020 00:58

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a27d3a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 54c276d into aws:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants