fix(region-info): incorrect S3 static website endpoint for us-gov-west-1 #10920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
reviewed
Oct 26, 2020
There was a problem hiding this comment.
change seems fine to me.
could you reword the title to indicate what's not working as it's our convention for fixes.
Rationale: when it shows up in the Bug Fixes section of the CHANGELOG in the next release - the line item describes the problem that was fixed.
| @@ -426,7 +426,7 @@ Object { | |||
| "cdkMetadataResourceAvailable": false, | |||
| "domainSuffix": "amazonaws.com", | |||
| "partition": "aws-us-gov", | |||
| "s3StaticWebsiteEndpoint": "s3-website.us-gov-west-1.amazonaws.com", | |||
| "s3StaticWebsiteEndpoint": "s3-website-us-gov-west-1.amazonaws.com", | |||
There was a problem hiding this comment.
was this endpoint incorrect previously?
There was a problem hiding this comment.
according to the documentation at least
PatMyron
changed the title
shivlaks
changed the title
shivlaks
approved these changes
Oct 26, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3-website-us-gov-west-1.amazonaws.comus-gov-west-1announced in Aug 2011#4584
aws-cdk/packages/@aws-cdk/region-info/build-tools/generate-static-data.ts
Lines 47 to 49 in 36fea28
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license