Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(aws-iam): Comments for allow and deny are reversed on PolicyStatement #1031

Closed
jonparker opened this issue Oct 29, 2018 · 0 comments
Closed

bug(aws-iam): Comments for allow and deny are reversed on PolicyStatement #1031

jonparker opened this issue Oct 29, 2018 · 0 comments

Comments

@jonparker
Copy link
Contributor

https://github.com/awslabs/aws-cdk/blob/c87f3ec6a598283281252eedcd49903a13dde291/packages/%40aws-cdk/aws-iam/lib/policy-document.ts#L270-L280

The allow method has the comment

Sets the permission effect to deny access to resources.

while the deny method has the comment

Sets the permission effect to allow access to resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonparker @eladb