From 07179194d8fc4e3beaeafbe6cf04a2f3d1addd2c Mon Sep 17 00:00:00 2001 From: Otto Jongerius Date: Thu, 9 Jul 2020 03:15:49 +1200 Subject: [PATCH 1/2] fix(cli): Python sample app template does not follow PEP8 (#8936) Classes should be surrounded by 2 blank lines according to PEP8 related PR: https://github.com/aws-samples/aws-cdk-intro-workshop/pull/142 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- .../%name.PythonModule%/%name.PythonModule%_stack.template.py | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/aws-cdk/lib/init-templates/sample-app/python/%name.PythonModule%/%name.PythonModule%_stack.template.py b/packages/aws-cdk/lib/init-templates/sample-app/python/%name.PythonModule%/%name.PythonModule%_stack.template.py index afc07081c834a..910a4b838c933 100644 --- a/packages/aws-cdk/lib/init-templates/sample-app/python/%name.PythonModule%/%name.PythonModule%_stack.template.py +++ b/packages/aws-cdk/lib/init-templates/sample-app/python/%name.PythonModule%/%name.PythonModule%_stack.template.py @@ -6,6 +6,7 @@ core ) + class %name.PascalCased%Stack(core.Stack): def __init__(self, scope: core.Construct, id: str, **kwargs) -> None: From c424c57fd04f860599b830a5f00b7fb6fb89f13d Mon Sep 17 00:00:00 2001 From: Jimmy Miller Date: Wed, 8 Jul 2020 11:36:37 -0400 Subject: [PATCH 2/2] docs(ecs): fix typo in awsLogs (#8878) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- packages/@aws-cdk/aws-ecs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@aws-cdk/aws-ecs/README.md b/packages/@aws-cdk/aws-ecs/README.md index 702c4617bace2..75c4ac3698e14 100644 --- a/packages/@aws-cdk/aws-ecs/README.md +++ b/packages/@aws-cdk/aws-ecs/README.md @@ -474,7 +474,7 @@ const taskDefinition = new ecs.Ec2TaskDefinition(this, 'TaskDef'); taskDefinition.addContainer('TheContainer', { image: ecs.ContainerImage.fromRegistry('example-image'), memoryLimitMiB: 256, - logging: ecs.LogDrivers.awslogs({ streamPrefix: 'EventDemo' }) + logging: ecs.LogDrivers.awsLogs({ streamPrefix: 'EventDemo' }) }); ```