From 50dbcec2c73c0ad75121f8ec2202f6ff97008cca Mon Sep 17 00:00:00 2001 From: Michael Sambol Date: Thu, 28 Mar 2024 11:28:43 -0600 Subject: [PATCH] add check for timestamp --- .../@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts | 2 +- .../aws-pipes-sources-alpha/test/kinesis.test.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts index 3739811bf457c..8a4ea428656e4 100644 --- a/packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts +++ b/packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts @@ -127,7 +127,7 @@ export class KinesisSource implements ISource { this.parallelizationFactor = this.sourceParameters.parallelizationFactor; this.deadLetterTarget = this.sourceParameters.deadLetterTarget; this.startingPosition = this.sourceParameters.startingPosition; - this.sourceParameters = this.sourceParameters.startingPositionTimestamp; + this.startingPositionTimestamp = this.sourceParameters.startingPositionTimestamp; if (this.batchSize !== undefined) { if (this.batchSize < 1 || this.batchSize > 10000) { diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts index 22e08db472a4c..e3dd294c49f9b 100644 --- a/packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts +++ b/packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts @@ -55,7 +55,7 @@ describe('kinesis source', () => { maximumRetryAttempts: 10, onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT, parallelizationFactor: 10, - startingPosition: KinesisStartingPosition.LATEST, + startingPosition: KinesisStartingPosition.AT_TIMESTAMP, startingPositionTimestamp: '2024-01-01T00:00:00Z', }); @@ -86,7 +86,7 @@ describe('kinesis source', () => { MaximumRetryAttempts: 10, OnPartialBatchItemFailure: 'AUTOMATIC_BISECT', ParallelizationFactor: 10, - StartingPosition: 'LATEST', + StartingPosition: 'AT_TIMESTAMP', StartingPositionTimestamp: '2024-01-01T00:00:00Z', }, }, @@ -107,7 +107,7 @@ describe('kinesis source', () => { maximumRetryAttempts: 10, onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT, parallelizationFactor: 10, - startingPosition: KinesisStartingPosition.LATEST, + startingPosition: KinesisStartingPosition.AT_TIMESTAMP, startingPositionTimestamp: '2024-01-01T00:00:00Z', }); @@ -143,7 +143,7 @@ describe('kinesis source', () => { MaximumRetryAttempts: 10, OnPartialBatchItemFailure: 'AUTOMATIC_BISECT', ParallelizationFactor: 10, - StartingPosition: 'LATEST', + StartingPosition: 'AT_TIMESTAMP', StartingPositionTimestamp: '2024-01-01T00:00:00Z', }, }, @@ -369,6 +369,6 @@ describe('kinesis source parameters validation', () => { startingPosition: KinesisStartingPosition.LATEST, startingPositionTimestamp: '2024-01-01T00:00:00Z', }); - }).toThrow('Timestamp only valid with StartingPosition AT_TIMESTAMP for Kinesis streams, received KinesisStartingPosition.LATEST'); + }).toThrow('Timestamp only valid with StartingPosition AT_TIMESTAMP for Kinesis streams, received LATEST'); }); });