From 0757f67cb47173e6be249fce5e15a3f601d4ee18 Mon Sep 17 00:00:00 2001 From: Cory Hall <43035978+corymhall@users.noreply.github.com> Date: Tue, 31 Jan 2023 08:23:28 -0500 Subject: [PATCH] chore: remove strict check on command arguments (#23927) As part of #23907 I updated the dependency on `@types/yargs` to be in the `15` major version to reflect the version we use in the rest of the repo. Version `15` did not have the `strictOptions` yargs method so I attempted to enable `strict()` and disable `strictCommands` but it looks like that doesn't work. Removing strict altogether. Our only other option is to keep `@types/yargs` pinned at `17.0.15` since `17.0.16` is no longer compatible with our version of typescript. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- packages/@aws-cdk-testing/cli-integ/bin/query-github.ts | 2 -- packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts | 2 -- packages/@aws-cdk-testing/cli-integ/bin/stage-distribution.ts | 2 -- 3 files changed, 6 deletions(-) diff --git a/packages/@aws-cdk-testing/cli-integ/bin/query-github.ts b/packages/@aws-cdk-testing/cli-integ/bin/query-github.ts index d21df9b5731a1..770932daa649b 100644 --- a/packages/@aws-cdk-testing/cli-integ/bin/query-github.ts +++ b/packages/@aws-cdk-testing/cli-integ/bin/query-github.ts @@ -24,8 +24,6 @@ async function main() { requiresArg: true, })) .demandCommand() - .strict() - .strictCommands(false) .help() .showHelpOnFail(false) .argv; diff --git a/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts b/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts index 009e39d74b49a..13ed1442bc35f 100644 --- a/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts +++ b/packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts @@ -62,8 +62,6 @@ async function main() { requiresArg: false, }) .help() - .strict() - .strictCommands(false) .showHelpOnFail(false) .argv; diff --git a/packages/@aws-cdk-testing/cli-integ/bin/stage-distribution.ts b/packages/@aws-cdk-testing/cli-integ/bin/stage-distribution.ts index 8ed5a737ab090..a5cfd6b496e5c 100644 --- a/packages/@aws-cdk-testing/cli-integ/bin/stage-distribution.ts +++ b/packages/@aws-cdk-testing/cli-integ/bin/stage-distribution.ts @@ -143,8 +143,6 @@ async function main() { }) .demandCommand(1, 'You must supply a command') .help() - .strict() - .strictCommands(false) .showHelpOnFail(false) .parse(); }