Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated API Warnings #287

Closed
11 tasks done
skinny85 opened this issue Feb 17, 2021 · 2 comments
Closed
11 tasks done

Deprecated API Warnings #287

skinny85 opened this issue Feb 17, 2021 · 2 comments
Labels
bar-raiser/assigned management/rfc status/api-approved API Bar Raiser signed-off the API of this RFC status/done Implementation complete

Comments

@skinny85
Copy link
Contributor

skinny85 commented Feb 17, 2021 •
edited by eladb
Loading

Description

If an element in the CDK Construct Library (class, interface, property, function, etc.) is deprecated, using it inside a CDK application should produce a warning in the CDK CLI for all commands that perform synthesis (cdk synth, cdk diff, cdk deploy, etc.).

This will aid in the migration from CDK V1 to V2.

Roles

Role User
Author(s) @skinny85
API Bar Raiser @eladb

See RFC Process for details

Workflow

  • Tracking issue created (label: status/proposed)
  • API bar raiser assigned (ping us at #aws-cdk-rfcs if needed)
  • Kick off meeting
  • RFC pull request submitted (label: status/review)
  • Community reach out (via Slack and/or Twitter)
  • API signed-off (label api-approved applied to pull request)
  • Final comments period (label: status/final-comments-period)
  • Approved and merged (label: status/approved)
  • Execution plan submitted (label: status/planning)
  • Plan approved and merged (label: status/implementing)
  • Implementation complete (label: status/done)

Author is responsible to progress the RFC according to this checklist, and
apply the relevant labels to this issue so that the RFC table in README gets
updated.
@skinny85 skinny85 self-assigned this Feb 17, 2021
@skinny85 skinny85 mentioned this issue Feb 18, 2021
Merged
@eladb eladb changed the title CDK CLI should warn when using deprecated APIs Deprecated API Warnings Mar 11, 2021
@nija-at nija-at mentioned this issue Jun 15, 2021
Merged
@eladb eladb added status/review Proposal pending review/revision and removed status/proposed Newly proposed RFC labels Jun 15, 2021
@skinny85 skinny85 removed their assignment Jun 22, 2021
@eladb
Copy link
Contributor

eladb commented Aug 4, 2021

@skinny85 has this been implemented already?

@eladb eladb added status/api-approved API Bar Raiser signed-off the API of this RFC status/approved Ready for implementation and removed status/review Proposal pending review/revision labels Aug 4, 2021
@skinny85
Copy link
Contributor Author

@eladb no, it has not - the design has been approved in the RFC, but the implementation work has not started.

@eladb eladb added status/done Implementation complete and removed status/approved Ready for implementation labels Dec 14, 2021
@snyk-bot snyk-bot mentioned this issue Aug 7, 2022
Open
@snyk-bot snyk-bot mentioned this issue Aug 16, 2022
Open
@mrgrain mrgrain closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bar-raiser/assigned management/rfc status/api-approved API Bar Raiser signed-off the API of this RFC status/done Implementation complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrgrain @skinny85 @eladb @evgenyka