Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct library pattern for grants #230

Closed
6 tasks
eladb opened this issue Apr 15, 2019 · 1 comment
Closed
6 tasks

Construct library pattern for grants #230

eladb opened this issue Apr 15, 2019 · 1 comment
Labels
status/stale The RFC did not get any significant enough progress or tracking and has become stale.

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019

  • Update guidelines with details on how to use the Grant API
  • Add "grant" to cdk.IResource
  • Implement and apply rule awslint:grants-on-interface: Grant methods should be on the construct interface, not the class
  • Implement and apply rule awslint:grants-grant-method: All constructs should have at least a single "grant" method with the defined signature
  • Implement and apply rule awslint:grants-signature: Grant methods should adhere to signature rules
  • Implement and apply rule awslint:grants-static-all: Static grant methods should be on the class and adhere to the signature and naming conventions
@eladb eladb changed the title Guidelines implementation: Grants awslint:grants May 1, 2019
@eladb eladb changed the title awslint:grants Construct library pattern for grants Jan 23, 2020
@rix0rrr rix0rrr closed this as completed Mar 3, 2020
@rix0rrr rix0rrr reopened this Mar 3, 2020
@eladb eladb transferred this issue from aws/aws-cdk Aug 17, 2020
@nija-at nija-at added the status/proposed Newly proposed RFC label Nov 11, 2020
@eladb eladb removed their assignment Feb 25, 2021
@mrgrain mrgrain added status/stale The RFC did not get any significant enough progress or tracking and has become stale. and removed status/proposed Newly proposed RFC labels Oct 27, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Oct 27, 2023

Marking this RFCs as stale since there has been little recent activity and it is not currently close to getting accepted as-is. We appreciate the effort that has gone into this proposal. Marking an RFCs as stale is not a one-way door. If you have made substantial changes to the proposal, please open a new issue/RFC. You might also consider raising a PR to aws/aws-cdk directly or self-publishing to Construct Hub.

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/stale The RFC did not get any significant enough progress or tracking and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrgrain @rix0rrr @eladb @nija-at