Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

fix(cli-integ): interactive cdk import test is unstable #76

Merged
merged 3 commits into from
Apr 8, 2025
Merged

fix(cli-integ): interactive cdk import test is unstable #76

merged 3 commits into from
Apr 8, 2025

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Apr 8, 2025 •
edited
Loading

Various enhancements in this PR:

  • Don't register a callback on stderr because it creates duplicate output.
  • Shift the interactions array before writing to stdin to prevent possible interaction reuse.
  • On interaction match, reset the lastLine we match on to prevent repeated matches due to tty echoing.
  • Make prompt matching in cdk import test be more specific to the requested input.

@iliapolo iliapolo temporarily deployed to integ-approval April 8, 2025 09:08 — with GitHub Actions Inactive
@iliapolo iliapolo temporarily deployed to integ-approval April 8, 2025 09:12 — with GitHub Actions Inactive
@iliapolo iliapolo marked this pull request as ready for review April 8, 2025 09:13
@rix0rrr rix0rrr disabled auto-merge April 8, 2025 09:30
rix0rrr
rix0rrr approved these changes Apr 8, 2025
View reviewed changes
@iliapolo iliapolo added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 1103cee Apr 8, 2025
19 checks passed
@iliapolo iliapolo deleted the epolon/interactive-fixes branch April 8, 2025 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@rix0rrr rix0rrr rix0rrr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iliapolo @rix0rrr