Is dockersock mount still needed?

[moensch]

I am running containerd on my hosts, provisioned via https://github.com/kubernetes-sigs/cluster-api-provider-aws (k8s 1.17.x) and my hosts don't run docker.

I noticed the DaemonSet still has these two volume mounts in both, the release YAML and the helm chart:

            - mountPath: /var/run/docker.sock
              name: dockersock
            - mountPath: /var/run/dockershim.sock
              name: dockershim

I found a merged PR that, as I understand it, made this project runtime agnostic: #371

With that in mind, is this socket mount still needed? I ask because on systems running containerd it does not exist.

[mogren]

Hi @moensch ,
You are correct that the docker.sock is not needed for v1.6.0 and later, but in case you want to roll back to v1.5.7 or any earlier version, it needs to be there. We kept it in the sample config for that reason but as you said, for running on containerd or CRI-O, you don't need to mount it at all.