Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomization.yaml #642

Closed
jwenz723 opened this issue Oct 3, 2019 · 3 comments
Closed

Add kustomization.yaml #642

jwenz723 opened this issue Oct 3, 2019 · 3 comments

Comments

@jwenz723
Copy link

jwenz723 commented Oct 3, 2019

I am trying to install the AWS VPC CNI with CNI Custom Networking feature enabled. I would like to be able to create a kustomize patch and apply it to the config/v1.5/aws-k8s-cni.yaml file without having to copy and paste the config/v1.5/aws-k8s-cni.yaml file into my repo (so that no one can make modifications to it from my org).

There is a way to accomplish this using the go-getter generator plugin as described here, but it would be nicer if the amazon-vpc-cni-k8s repo just contained a kustomization.yaml file so it could be referenced directly as a kustomize base/resource without the need for a custom generator plugin.

This would allow for my kustomization.yaml file to look something like this to apply my patch for CNI Custom Networking:

patchesStrategicMerge:
  - aws-node-patch.yaml

resources:
- github.com/aws/amazon-vpc-cni-k8s//config/v1.5?ref=v1.5.4 // this assumes that there is a kustomization.yaml file within the config/v1.5 directory
@jaypipes
Copy link
Contributor

Related: #758

Hi @jwenz723! Our long-term plan is to get rid of the versioned subdirectories under /config and use a single daemonset.yaml file (possibly using kustomize). Also, per #758, our best practice is standardizing around Helm charts for deploying the CNI.

I think supporting Kustomize is a good idea and something we should look at once we move to a single config/ directory.

@jwenz723
Copy link
Author

jwenz723 commented Feb 8, 2020

A helm chart could likely work for what I do. Thanks for the update.

@mogren
Copy link
Contributor

mogren commented Apr 22, 2020

@mogren mogren closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants