Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No version number reported in CloudTrail history. #2518

Closed
guessi opened this issue Aug 30, 2023 · 3 comments
Closed

No version number reported in CloudTrail history. #2518

guessi opened this issue Aug 30, 2023 · 3 comments

Comments

@guessi
Copy link
Contributor

guessi commented Aug 30, 2023

What happened:

While troubleshooting VPC CNI related event, it is better to have version number included.

But the fact is that there's no version number reported in CloudTrail history, hard to tell which version was applied.

Version defined HERE and HERE seems like not defined, but I'm not sure how to fix it correctly, so I create the bug report here.

image

Attach logs

n/a

What you expected to happen:

Version info should be included in CloudTrail events.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

It's a long lasting bug, version is not that important.

@jdn5126
Copy link
Contributor

jdn5126 commented Aug 30, 2023

This is a good call out @guessi , thank you for the report! Yeah, that version variable should be set based on the current VPC CNI version. We should do the same for our Kubernetes client userAgent: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/k8sapi/k8sutils.go#L174

I marked this as a good first issue, and will try to find someone to work on this.

@jdn5126
Copy link
Contributor

jdn5126 commented Sep 22, 2023

Closing as this merged in #2566 and will ship in v1.15.1

@jdn5126 jdn5126 closed this as completed Sep 22, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants