Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for Describe calls and other EC2 API Calls in CNI Metrics helper #2035

Closed
jayanthvn opened this issue Jul 20, 2022 · 7 comments
Closed

Add metrics for Describe calls and other EC2 API Calls in CNI Metrics helper #2035

jayanthvn opened this issue Jul 20, 2022 · 7 comments
Labels
enhancement feature request help wanted stale Issue or PR is stale

Comments

@jayanthvn
Copy link
Contributor

What would you like to be added:
CNI Metrics helper today includes metrics around ipamd datastore - https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/ipamd/ipamd.go#L177-L230. It would be good to add metrics for all the EC2 calls made by IPAMD and expose it with CNI Metrics helper.

Why is this needed:
This would give better UX and easy access to number of EC2 calls made per node.
@jayanthvn jayanthvn changed the title Add metrics for Describecall and other EC2 API Calls in CNI Metrics helper Add metrics for Describe calls and other EC2 API Calls in CNI Metrics helper Jul 20, 2022
@sidewinder12s
Copy link

Currently users have to contact AWS Support to get these enabled on the AWS side rather than directly from the CNI: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/monitor.html

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Sep 26, 2022
@github-actions
Copy link

Issue closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2022
@jayanthvn jayanthvn reopened this Oct 10, 2022
@jayanthvn
Copy link
Contributor Author

/not stale

@github-actions github-actions bot removed the stale Issue or PR is stale label Oct 11, 2022
@jaydeokar jaydeokar mentioned this issue Nov 15, 2022
Merged
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Dec 11, 2022
@jayanthvn
Copy link
Contributor Author

2142 is merged.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request help wanted stale Issue or PR is stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayanthvn @sidewinder12s