Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Stack Parameters does not propagate to Step Functions #22

Closed
billyjbryant opened this issue Jun 27, 2023 · 5 comments
Closed

Comments

@billyjbryant
Copy link

Describe the bug
If you update the stack and provide new parameters for Source, Login, teamAdminGroup and teamAuditGroup, the stack updates but the step functions are not updated accordingly as the template that deploys the Step functions via stackset is not re-generated and deployed.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy the stack using CDK's CfnInclude functionality
  2. Update the parameters passed to the stack after initial deployment
  3. Validate that the parameters have not been updated in the application post-update deployment.

Expected behavior
Any update to the parameters in the stack should trigger a reactionary deployment that updates all functions accordingly.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

The complication to this is that I am deploying the stack by including into a CDK app using cdk.CfnInclude, so there may be a disconnect here that is preventing the follow-up deployment.

@tawoyinfa
Copy link
Contributor

@billyjbryant updating the stack paramater will not result in a change in the step function definition. The step function will be updated only when there is an actual change in the state machine definition.

I am keen to see how are deploying the stack/solution in a CDK app. Is there a reason you are not using the existing deployment process ?

Also not that there is a script that is built into the amplify pipeline that updates the stack paramaters during deployment.

@billyjbryant
Copy link
Author

I am keen to see how are deploying the stack/solution in a CDK app.

in my initial deployment, I used CfnInclude to include the Cloudformation Template into my CDK App. In my second deployment, I have completely re-written the Cloudformation Template as a CDK App.

Is there a reason you are not using the existing deployment process ?

Yes, our organization prefers CDK as we can abstract permissions. IE I can permit a user to assume a CDK Role that will allow deploying the CDK Stack but not have to give direct permissions to deploy the CFN Template natively etc. It also allows for analyzing CFN Template structure and adherence to best practices by implementing cfn-nag into the CDK App.

@jasonbrd
Copy link

Supporting updates to the teamAdminGroup and teamAuditGroup may be useful to customers if groups need to change without destroying the environment, defined policies, audit history etc.

@tawoyinfa
Copy link
Contributor

@jasonbrd can you raise this as a feature request and we can prioritize this accordingly.

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants