Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

(Still) Incomplete cleanup #705

Closed
yairst opened this issue Oct 7, 2022 · 1 comment
Closed

(Still) Incomplete cleanup #705

yairst opened this issue Oct 7, 2022 · 1 comment
Labels
bug This issue is a bug. language/python Related to the Python workshop needs-reproduction This issue needs reproduction. p1

Comments

@yairst
Copy link

yairst commented Oct 7, 2022

Describe the bug

The clean up stage has been recently updated in #592 to include RemovalPolicy for the dynamoDB table.
However, running cdk destroy right after adding the RemovalPolicy prop to the code does not delete the table.

Expected Behavior

DynamoDB table should be deleted.

Current Behavior

DynamoDB table is retained after cdk destroy.

Reproduction Steps

Assuming that you have a cdk-workshop stack in a state as it should be before running the steps in the clean up stage:

  1. Follow the instructions on clean up stage: add RemovalPolicy to the table code and run cdk destroy.
  2. Go AWS DynamDB console and see that the table is still there.

Possible Solution

Run cdk deploy first in order to update the table and only then run cdk destroy.

Additional Information/Context

No response

CDK CLI Version

No response

Section

No response

Browser

No response

Language

No response

@yairst yairst added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 7, 2022
@indrora indrora added language/python Related to the Python workshop p1 needs-reproduction This issue needs reproduction. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2023
@kellertk kellertk closed this as completed Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. language/python Related to the Python workshop needs-reproduction This issue needs reproduction. p1
Projects
None yet
Development

No branches or pull requests

3 participants