Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: make Powertools UA middleware detection more robust #1761

Closed
1 of 2 tasks
dreamorosi opened this issue Oct 21, 2023 · 2 comments · Fixed by #1762
Closed
1 of 2 tasks

Maintenance: make Powertools UA middleware detection more robust #1761

dreamorosi opened this issue Oct 21, 2023 · 2 comments · Fixed by #1762
Assignees
Labels
commons This item relates to the Commons Utility completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

AWS SDK can have only one middleware with the same identifier in the same middleware stack. In order to avoid hitting this error we currently try to compare the ids of the middlewares present in a client middleware stack before attempting to attach our own.

The current method does an exact string comparison using the id of the middleware, as well as other metadata, which can be problematic in case the middleware stack order changes or the information returned by the client.middlewareStack.identify() function changes.

We should move to a more loose comparison to instead check for the middleware id only.

Why is this needed?

To decrease the chance of false positives, and ultimately be able to attach the middleware correctly.

Which area does this relate to?

Other

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation commons This item relates to the Commons Utility labels Oct 21, 2023
@dreamorosi dreamorosi self-assigned this Oct 21, 2023
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Oct 21, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Oct 21, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

This is now released under v1.14.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Nov 1, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commons This item relates to the Commons Utility completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
1 participant