Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Signing AWS Request #2493

Open
2 tasks done
stephenbawks opened this issue Jun 17, 2023 · 4 comments · May be fixed by #2435
Open
2 tasks done

Feature request: Signing AWS Request #2493

stephenbawks opened this issue Jun 17, 2023 · 4 comments · May be fixed by #2435
Labels
feature-request feature request

Comments

@stephenbawks
Copy link
Contributor

Use case

Certain AWS Services need to be signed with Signature V4.

https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html

Solution/User Experience

I am proposing adding a new class that will take in the parameters to create this signed request for the end user to simplify it since it is not a very straightforward method and should be made easier.

Alternative solutions

No response

Acknowledgment

@stephenbawks stephenbawks added feature-request feature request triage Pending triage from maintainers labels Jun 17, 2023
@leandrodamascena
Copy link
Contributor

leandrodamascena commented Jun 20, 2023

Hi @stephenbawks Thank you so much for opening this issue to add this new support, we really see value in this addition. As I see in #2435, you're using functions provided by botocore and that's awesome because botocore is included by default in the Lambda Runtime and we don't need to bring one more dependency.

However, before we move forward with this new utility, we really need to create an RFC to further discuss this implementation. Imagine we just merged PR #2435, customers start using this and we need to add more features and other utilities related to signed requests or JWT token for example? Will we have problems with changes breaking? Do we already have a good design that allows adding more features? We should have another developer experience for this case?

Let me give you a real example why we need an RFC for this: we already have an issue opened that can be added to this new utility - #1174.

So, do you think you can start creating an RFC? Can I help you? You can use this RFC as an example to create a new one - #2421.

Thank you so much for taking the time to add value to Powertools, it is priceless and I cannot express our gratitude enough.

@leandrodamascena leandrodamascena added need-rfc and removed triage Pending triage from maintainers labels Jun 20, 2023
@stephenbawks
Copy link
Contributor Author

I will get it done.

@rubenfonseca rubenfonseca self-assigned this Jun 28, 2023
@heitorlessa heitorlessa linked a pull request Jul 10, 2023 that will close this issue
7 tasks
@heitorlessa heitorlessa self-assigned this Feb 9, 2024
@heitorlessa
Copy link
Contributor

Assigning to me for review and scheduled for the next iteration cycle starting on Monday :)

Appreciate your patience while we had many loose ends to take care of

@heitorlessa
Copy link
Contributor

I've started the Parameters/Secrets one, once complete we can move to this one. I've tentatively moved to early April as I'll be on holidays too on mid-March

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request
Projects
Status: Backlog
4 participants